Updated tooling to latest main #481
Conversation
Arlodotexe
added
bug 🐛
|
Hit CommunityToolkit/Tooling-Windows-Submodule#5 and had to remove the empty AppServices sample project to move forward for now. |
|
Will need this patch as well - CommunityToolkit/Tooling-Windows-Submodule#113 |
|
Investigation into CI errors is continuing here - CommunityToolkit/Windows#157 |
michael-hawker
force-pushed
the
update/tooling
branch
from
1ef3c52
to
17ef82a
Compare
|
@Arlodotexe updated this PR/branch based on CommunityToolkit/Tooling-Windows-Submodule#116 and made the other required changes. We'll see if this works now, big test... 🤞 This does mean with the automated versioning each PR will update all the packages, will need to look at the https://github.com/marketplace/actions/changed-files tool to look at only pushing packages with changes later... |
There was a problem hiding this comment.
Alright, hopefully we're all in-sync now.
Appears the root of the issue was the change made to the FrameworkElment AncestorType method signature based on a proposed bug fix. As it should only attach to FrameworkElement and not DependencyProperty.
However, this caused a signature mismatch and nuget resolution was pulling the prior packages still until we've re-aligned here. Hopefully, we won't hit this in the future again... but at least have some better ideas about what happened and how it can manifest, though it wasn't the easiest to catch at first, the output from the CI when the test app crashes is fairly non-existent. I had a lot of issues getting logging to work, and upgrading to the latest test code is blocked on WASDK, see microsoft/testfx#1726. So future improvements are needed later.
In a dedicated PR to catch potential build errors.